Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[addons/awscsidriver] Bump to GA release #11418

Merged
merged 1 commit into from
May 8, 2021
Merged

[addons/awscsidriver] Bump to GA release #11418

merged 1 commit into from
May 8, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented May 8, 2021

Bump version and manifests of AWS EBS CSI Driver to the first GA release.

Signed-off-by: dntosas ntosas@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2021
@olemarkus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2021
olemarkus
olemarkus reviewed May 8, 2021
View reviewed changes
upup/models/cloudup/resources/addons/aws-ebs-csi-driver.addons.k8s.io/k8s-1.17.yaml.template Outdated
subjects:
- kind: ServiceAccount
name: ebs-csi-node-sa
namespace: default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the default namespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg, thanks for catching ^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2021
@dntosas
[addons/awscsidriver] Bump to GA release
f8ece50 
Bump version and manifests of AWS EBS CSI Driver to the first GA
release.

Signed-off-by: dntosas <ntosas@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2021
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2021
@olemarkus
Copy link
Member

Thanks. I think these can be cherry-picked back to 1.20.

@k8s-ci-robot k8s-ci-robot merged commit 7db45cb into kubernetes:master May 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone May 8, 2021
This was referenced May 8, 2021
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 8, 2021
@k8s-ci-robot
Merge pull request #11423 from olemarkus/automated-cherry-pick-of-#11…
cfb5dbd 
…418-origin-release-1.21

Automated cherry pick of #11418: Bump to GA release
k8s-ci-robot added a commit that referenced this pull request May 8, 2021
@k8s-ci-robot
Merge pull request #11424 from olemarkus/automated-cherry-pick-of-#11…
3025905 
…304-#11326-#11418-origin-release-1.20

Automated cherry pick of #11304: [csi/aws] Bump templates to latest#11326: Fix arguments to csi-provisioner after bump to v2.2.0#11418: Bump to GA release
@johngmyers johngmyers modified the milestones: v1.21, v1.22 May 10, 2021
@dntosas dntosas mentioned this pull request Oct 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@dntosas @k8s-ci-robot @olemarkus @johngmyers